Skip to content
d3 Wiki
03.05

Pull request process and review checklist

Every change gets a second set of eyes without becoming a bottleneck.

Updated
Oct 3, 2026
On this page

Purpose

Every change gets a second set of eyes without becoming a bottleneck.

The standard

  • PRs are small: aim for under ~400 changed lines. Bigger → split.

  • PR description uses the template: What / Why / How to test / Screenshots / Checklist.

  • One approval required; the owner of the affected tool (CODEOWNERS) is auto-requested.

  • Reviewers respond within one working day. Author resolves comments; reviewer re-approves.

  • CI (lint, types, tests, build) must be green. Preview deploy link is checked by the reviewer for web PRs.

  • Author merges (squash) and deletes the branch.

Review checklist

  • Does what the description says; nothing unrelated snuck in

  • Naming and structure per 01.05 / 02.03

  • No secrets, no console.log debris, no commented-out code

  • Errors handled and logged per 04.06

  • Tests added or updated per 04.05

  • DB changes are a migration (09.03) and RLS is correct (08.03)

  • Docs/README/wiki updated if behavior or a standard changed

Anti-patterns

Rubber-stamping; nitpicking style that a linter should catch; "LGTM" without running the preview.

Owner: Matt · Last reviewed: 2026-09